Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphs not scaling (sticking to ranges 0-1) #199

Closed
mmaucher opened this issue Nov 11, 2014 · 4 comments
Closed

Graphs not scaling (sticking to ranges 0-1) #199

mmaucher opened this issue Nov 11, 2014 · 4 comments

Comments

@mmaucher
Copy link

Similar to issue #197 (my fittings posted there now are displayed correctly), for some fittings the dps graph window still doesn't scale to the correct intervals, status bar says "Invalid values in build ".

screenshot 2014-11-11 12 51 36

This happens e.g. with this build:
[Rattlesnake, L4 PvE Pi !]

Damage Control II
Drone Damage Amplifier II
Drone Damage Amplifier II
Ballistic Control System II
Caldari Navy Ballistic Control System
Caldari Navy Ballistic Control System

Adaptive Invulnerability Field II
Adaptive Invulnerability Field II
F-90 Positional Sensor Subroutines, Targeting Range Script
Large Micro Jump Drive
Phased Weapon Navigation Array Generation Extron
Omnidirectional Tracking Link II, Optimal Range Script
Omnidirectional Tracking Link II, Optimal Range Script

'Arbalest' Cruise Launcher I, Caldari Navy Scourge Cruise Missile
'Arbalest' Cruise Launcher I, Caldari Navy Scourge Cruise Missile
Caldari Navy Cruise Missile Launcher, Caldari Navy Scourge Cruise Missile
Caldari Navy Cruise Missile Launcher, Caldari Navy Scourge Cruise Missile
Caldari Navy Cruise Missile Launcher, Caldari Navy Scourge Cruise Missile
Drone Link Augmentor I

Large Warhead Calefaction Catalyst I
Large Drone Scope Chip I
Large Drone Control Range Augmentor I

Vespa EC-600 x5
Hobgoblin II x5
Warden I x2
Ogre I x2
Scourge Cruise Missile x1
Optimal Range Script x1
Targeting Range Script x1

@mmaucher
Copy link
Author

When Pyfa runs long enough (and maybe has loaded enough other fittings), the bug seems to vanish.
After trying out different fittings today, at some point the graph window accepted all my fittings.

@blitzmann
Copy link
Collaborator

With this, I'm not getting an "Invalid Values" message. However, with the rattle snake fit, I do not see a graph unless you input a value into the target sig radius.

@blitzmann
Copy link
Collaborator

I removed a try...except block and got this for the rattlesnake (other fits seem fine). It seems to be affected by a feature I did to incorporate EW (projected target painters and webs). Webs seems to work as intended, but target painters are the issue. Confirmed by removing target painter on Rattlesnake, which then loads fine. Most likely due to Target Sig Size being None -- with a target painter an no set target size, it doesn't know what to do. Fix will probably just be to include a try...except block and silently fail if an issue arises. OR including a default sig radius, something large (like titan large) and disallowing it to be None

Traceback (most recent call last):
  File "C:\Users\Ryan\Dropbox\Git\blitzmann\Pyfa\gui\mainFrame.py", line 644, in openGraphFrame
    self.graphFrame = GraphFrame(self)
  File "C:\Users\Ryan\Dropbox\Git\blitzmann\Pyfa\gui\graphFrame.py", line 113, in __init__
    self.select(0)
  File "C:\Users\Ryan\Dropbox\Git\blitzmann\Pyfa\gui\graphFrame.py", line 183, in select
    self.draw()
  File "C:\Users\Ryan\Dropbox\Git\blitzmann\Pyfa\gui\graphFrame.py", line 194, in draw
    success, status = view.getPoints(fit, values)
  File "C:\Users\Ryan\Dropbox\Git\blitzmann\Pyfa\gui\builtinGraphs\fitDps.py", line 91, in getPoints
    for point, val in fitDps.getIterator():
  File "C:\Users\Ryan\Dropbox\Git\blitzmann\Pyfa\eos\graph\__init__.py", line 53, in _iterator
    yield point, self.function(point)
  File "C:\Users\Ryan\Dropbox\Git\blitzmann\Pyfa\eos\graph\fitDps.py", line 56, in calcDps
    val *= 1 + (bonus - 1) * exp(- i ** 2 / 7.1289)
TypeError: unsupported operand type(s) for *=: 'NoneType' and 'float'

@blitzmann
Copy link
Collaborator

Gonna make it a try-except.

Should be noted that the status bar should tell you if there is an error, but for me it doesn't. If there is ever an error, it quickly flashes with the error but then disappears. Probably due to being reset somewhere in a loop. I'll have to look into that at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants