Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated code in ClassDef._infer_type_call and BoundMethod._infer_type_new_call #247

Open
pylint-bot opened this issue Nov 5, 2015 · 1 comment
Open

Duplicated code in ClassDef._infer_type_call and BoundMethod._infer_type_new_call #247

pylint-bot opened this issue Nov 5, 2015 · 1 comment
Labels
enhancement

Comments

@pylint-bot
Copy link
Owner

Originally reported by: BitBucket: ceridwenv, GitHub: ceridwenv

These two methods are doing very similar things, building a ClassDef node for the result of a call of type, to the point that when I was fixing bugs in modular-locals I was literally copy-pasting code from one to the other.
@pylint-bot
Copy link
Owner Author

Original comment by Claudiu Popa (BitBucket: PCManticore, GitHub: PCManticore):

In 2.0 BoundMethod._infer_type_new_call is moved in brain by the way. Also, they are doing different things, even though they share some code. One of them could be implemented in terms of the other in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pylint-bot