-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose typing information #1287
Comments
Hello, we already spent hundred of hours in this, as @DanielNoord can corroborate 😄 We're close to being able to activate mypy, probably not with This is a prerequisite to doing the same in Pylint. |
Wow, great! I guess you then also expose the types by adding a |
Yes, once we've enabled mypy and can be confident the types are correct. |
Hi guys, |
The bottleneck in pylint performance is not pylint itself but in astroid and astroid is not typed properly right now (We can't even activate mypy in non strict mode). But we exposed pylint's typing becase there's some level of separation between pylint and astroid, and most pylint API do not expose astroid's API, so it's correct enough and useful enough to be exposed. There's another possible avenue for improvement on top of mypyc in #2014 but in all case it seems a major refactor with huge breaking changes is required to be able to type astroid correctly (#2014 (comment)) -- or do anything really. |
Thanks for the insights! |
Hi all,
if a library is using astroid and would like to check types (e.g. with mypy), the library first needs to have typing information and expose a "py.typed" file in the root package. First is partially done (AFAIK) but second not.
Can you please consider this?
The text was updated successfully, but these errors were encountered: