Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider caching removed in #1747 #2124

Closed
jacobtylerwalls opened this issue Apr 17, 2023 · 1 comment
Closed

Reconsider caching removed in #1747 #2124

jacobtylerwalls opened this issue Apr 17, 2023 · 1 comment
Labels
Duplicate 🐫 topic-performance

Comments

@jacobtylerwalls
Copy link
Member

Steps to reproduce

When running pylint on one submodule of the pylint primer, music21.stream.core, the caching removed in #1747 causes 2,711 calls to self.file_from_module_name(modname, context_file) for the module name music21.

Look into whether we can reintroduce some sort of caching without recausing pylint-dev/pylint#5151.
@jacobtylerwalls
Copy link
Member Author

Closing as duplicate of #2041.

@jacobtylerwalls jacobtylerwalls closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2023
This was referenced Apr 17, 2023
Closed
Merged
@jacobtylerwalls jacobtylerwalls mentioned this issue Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Duplicate 🐫 topic-performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacobtylerwalls