Visit PEP 695 nodes in get_children()
#2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
=======================================
Coverage 92.86% 92.86%
=======================================
Files 94 94
Lines 11066 11068 +2
=======================================
+ Hits 10276 10278 +2
Misses 790 790
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pierre-Sassoulas
previously approved these changes
Oct 28, 2023
|
Let's wait for 3.1, this is basically a new feature (and it's not blocking any pylint false positives). |
Pierre-Sassoulas
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Refs pylint-dev/pylint#9193
Noticed that without this PR, we don't check these nodes for
invalid-name.