Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint default disabled checkers should be a separate parameter from user-defined #1353

Closed
fermulator opened this issue Mar 1, 2017 · 1 comment

Comments

@fermulator
Copy link

fermulator commented Mar 1, 2017

as a child from #1352

Steps to reproduce

  1. run : "python -m pylint --generate-rcfile | grep disable="
  2. users then either:
    a) wipe that list, and define their own custom disabled checkers
    b) append to that list and never think about it again
    c) they dont' change it
    d) meticulously maintain diffs

Current behavior

For users (c) that do not use a rcfile with "disable=", when pylint adds new default disabled checkers, they benefit from the optimization.

But for (a) or (b) users, they'll never benefit from future additions/removals from the pylint project for this list.

This current list is documented : https://pylint.readthedocs.io/en/latest/reference_guide/features.html#messages-control-options

Expected behavior

TBD

I was thinking, as an enhancement, to support a /new/ (hidden?) parameter like "default-disable=...".
Let users specify their own disabled checkers without wiping or having to manage the built-in pylint disabled checkers;

If a user /DOES/ want to run a checker which is disabled by default, they can just have "enable=" after it.

pylint --version output

$ python35 -m pylint --version
No config file found, using default configuration
main.py 1.5.5,
astroid 1.4.5
Python 3.5.1 (default, Dec 11 2015, 13:17:22)
[GCC 4.8.3 20140911 (Red Hat 4.8.3-9)]

@Pierre-Sassoulas Pierre-Sassoulas added the Needs decision 🔒 Needs a decision before implemention or rejection label Jun 29, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.0 milestone Jun 29, 2022
@DanielNoord
Copy link
Collaborator

I don't think this is a good idea. With improved documentation and the --generate-toml-config flag you can already see what the default disables are. You can then add on to this.
This adds unnecessary complexity to configuration handling which should be solved by clearer documentation and usability improvements to the pylint-config command.

I'd vote to close.

@Pierre-Sassoulas Pierre-Sassoulas closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2022
@Pierre-Sassoulas Pierre-Sassoulas added Won't fix/not planned and removed Needs decision 🔒 Needs a decision before implemention or rejection labels Jul 2, 2022
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.15.0 milestone Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants