Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make consider-using-augmented-assign an extension #7605

Closed
DanielNoord opened this issue Oct 11, 2022 · 2 comments · Fixed by #7628
Closed

Make consider-using-augmented-assign an extension #7605

DanielNoord opened this issue Oct 11, 2022 · 2 comments · Fixed by #7628
Assignees
Labels
Enhancement ✨ Improvement to a component Optional Checkers Related to a checked, disabled by default
Milestone

Comments

@DanielNoord
Copy link
Collaborator

DanielNoord commented Oct 11, 2022

I haven't followed the discussion around this check so it might have come up already.

Why was this not implemented as an optional extension?

From what I can tell there is no obvious benefit to using the augmented assignment over the regular one. IMO it just creates a lot of unnecessary noise. Similar checks like the one for assignment expressions are also optional.

Originally posted by @cdce8p in #7514 (comment)

@cdce8p should this be in CodeStyle? Or just a full extension?

@DanielNoord DanielNoord added Enhancement ✨ Improvement to a component Blocker 🙅 Blocks the next release labels Oct 11, 2022
@DanielNoord DanielNoord added this to the 2.16.0 milestone Oct 11, 2022
@cdce8p
Copy link
Member

cdce8p commented Oct 11, 2022

@cdce8p should this be in CodeStyle? Or just a full extension?

consider-using-tuple and consider-using-assignment-expr are part of the CodeStyle extension, too. So I think there is an argument for it here.

A bit off-topic, I think it would be awesome if we could disable all CodeStyle checks by default so that users can / must choose which ones they want to enable. Haven't checked if that's already possible.

@cdce8p cdce8p added the Optional Checkers Related to a checked, disabled by default label Oct 11, 2022
@Pierre-Sassoulas
Copy link
Member

consider-using-tuple and consider-using-assignment-expr are part of the CodeStyle extension, too. So I think there is an argument for it here.

Agreed.

I think it would be awesome if we could disable all CodeStyle checks by default so that users can / must choose which ones they want to enable. Haven't checked if that's already possible.

Agree with you @cdce8p, we're delaying #3512 but it's one of the most important issue to fix at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component Optional Checkers Related to a checked, disabled by default
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants