Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add destructive rewrites for Cholesky Op #572

Closed
jessegrabowski opened this issue Jan 5, 2024 · 0 comments · Fixed by #1028
Closed

ENH: Add destructive rewrites for Cholesky Op #572

jessegrabowski opened this issue Jan 5, 2024 · 0 comments · Fixed by #1028

Comments

@jessegrabowski
Copy link
Member

Before

No response

After

No response

Context for the issue:

Currently, the Cholesky Op does not act in-place. This is a known problem since the Theano days (see comment here). We should:

  1. Add a rewrite that will set destructive=True to cholesky nodes,
  2. Add a destroy_map to Cholesky nodes
  3. Register the rewrite somewhere after the specialization step (this is done by other destructive rewrites, e.g. for GEMV.

If anyone knows other linear algebra Ops that are not acting in-place, this issue could also collect those (SolveTriangular?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment