Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on SaturationTransformation internals #1056

Open
wd60622 opened this issue Sep 20, 2024 · 0 comments
Open

Rely on SaturationTransformation internals #1056

wd60622 opened this issue Sep 20, 2024 · 0 comments

Comments

@wd60622
Copy link
Contributor

wd60622 commented Sep 20, 2024

The _plot_response_curve_fit function in the MMM class can rely on the sample_curve method of the SaturationTransformation class.

From there, the quantiles can all be calculated at once instead of by channel. The current limitation of the sample_curve is that all of the
x values are in their scaled form, so the channel loop would have to scale back the x values to their original form.

y_fit = self.saturation.function(
x=x_fit, **mid_params[channel]["saturation_params"]
).eval()
y_fit_lower = self.saturation.function(
x=x_fit, **lower_params[channel]["saturation_params"]
).eval()
y_fit_upper = self.saturation.function(
x=x_fit, **upper_params[channel]["saturation_params"]
).eval()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant