Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pynamo's session handling doesn't handle ConnectionError failures #98

Closed
ryan-lane opened this issue Feb 24, 2016 · 10 comments
Closed

Pynamo's session handling doesn't handle ConnectionError failures #98

ryan-lane opened this issue Feb 24, 2016 · 10 comments

Comments

@ryan-lane
Copy link

When a ConnectionError is through from botocore, the error is raised all the way through. Pynamo should catch the error and re-make the connection, then retry the request.

@pior
Copy link
Contributor

pior commented Mar 2, 2016

@ryan-lane this is probably related to #72. You can freeze to version 1.4.2 to revert to botocore doing all the job.

@jlafon
Copy link
Contributor

jlafon commented Mar 2, 2016

I think this is a good idea. PRs are welcome.

@pior
Copy link
Contributor

pior commented Mar 2, 2016

@jlafon Can we expect a release soon if PRs were provided for this bug and #99 ?

We are considering options for a project about to be released...

@jlafon
Copy link
Contributor

jlafon commented Mar 2, 2016

@pior yes I'd be happy to push a new release

@brln
Copy link
Contributor

brln commented Mar 4, 2016

+1, also seeing this bug in production.

@dkarchmer
Copy link

+1. Getting random, infrequent connection errors which I am not really sure how to handle. Is there a recommended way to handle this now?

@pior
Copy link
Contributor

pior commented Apr 6, 2016

@jlafon So finally, I won't be able to work on that.

Botocore has a lot of interesting tweaks, and good error handling.
It seems quite weird to duplicate this into PynamoDB.

We decided to stay on 1.4.2 with some backported fixes : ludia@3cc24e7

@brln
Copy link
Contributor

brln commented May 4, 2016

Has this been resolved, or are there any plans to resolve it? @pior are you saying that 1.4.2 doesn't have these problems? This is causing major problems in production for us.

@danielhochman
Copy link
Contributor

ConnectionErrors are still unhandled in the current release. I expect to have a fix and a new release ready by the end of next week.

@danielhochman
Copy link
Contributor

Fixed on devel. Unfortunately limits are currently broken on devel. Once they're fixed I'll cut a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants