-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pynamo's session handling doesn't handle ConnectionError failures #98
Comments
@ryan-lane this is probably related to #72. You can freeze to version 1.4.2 to revert to botocore doing all the job. |
I think this is a good idea. PRs are welcome. |
@pior yes I'd be happy to push a new release |
+1, also seeing this bug in production. |
+1. Getting random, infrequent connection errors which I am not really sure how to handle. Is there a recommended way to handle this now? |
@jlafon So finally, I won't be able to work on that. Botocore has a lot of interesting tweaks, and good error handling. We decided to stay on 1.4.2 with some backported fixes : ludia@3cc24e7 |
Has this been resolved, or are there any plans to resolve it? @pior are you saying that 1.4.2 doesn't have these problems? This is causing major problems in production for us. |
ConnectionErrors are still unhandled in the current release. I expect to have a fix and a new release ready by the end of next week. |
Fixed on devel. Unfortunately limits are currently broken on devel. Once they're fixed I'll cut a new release. |
When a ConnectionError is through from botocore, the error is raised all the way through. Pynamo should catch the error and re-make the connection, then retry the request.
The text was updated successfully, but these errors were encountered: