node tests fail if run inside nox

[joemarshall]

If I run tests for urllib3 against node.js they fail. This is because it uses nox, which in turn runs pytest as a subprocess. Somewhere along the way nox manages to do something to the tty so that NodeRunner.run_js only sends the first 4096 characters of the javascript along.

I can see that we call stty -icanon to try and stop this happening, but for some reason in this case it fails.

Possibly it would make sense to split the strings into e.g. 128 character lines, and then concatenate them to the code string without adding a \n in the javascript test runner unless it receives an entirely blank line which can be a \n. That way it should work whatever the tty settings.

[ryanking13]

I guess we can close this? @joemarshall