Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github action #781

Open
FFY00 opened this issue May 28, 2024 · 4 comments
Open

Add Github action #781

FFY00 opened this issue May 28, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@FFY00
Copy link
Member

FFY00 commented May 28, 2024

Similar to https://github.com/pypa/gh-action-pypi-publish but to build packages.

@FFY00 FFY00 added the enhancement New feature or request label May 28, 2024
@henryiii
Copy link
Contributor

henryiii commented May 28, 2024

I think this would basically be https://github.com/hynek/build-and-inspect-python-package except without the validation? Edit: also no auto archive uploads.

@FFY00
Copy link
Member Author

FFY00 commented May 28, 2024

Yes, I wasn't aware of that, maybe it doesn't make much sense then though.

@henryiii
Copy link
Contributor

Build uses it. :) It also uses uv and our --installer=uv option, so it's really fast. Not sure we could do better. If we could provide an action that was flexible enough that action could use, though, I think that might be worth while.

(Actually, I use it in so many of my repos that I spent 10 minutes looking for an example of someone learning recently to find one that didn't use it)

@FFY00
Copy link
Member Author

FFY00 commented May 29, 2024

Okay, today I ran into a use-case where that action is a bit undesirable. I want to build a wheel as an intermediary step, and hynek's action always uploads the artifact, which is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants