Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building sdist uses wrong gitignore #1641

Closed
blmaier opened this issue Jul 25, 2024 · 0 comments · Fixed by #1643
Closed

Building sdist uses wrong gitignore #1641

blmaier opened this issue Jul 25, 2024 · 0 comments · Fixed by #1643

Comments

@blmaier
Copy link

blmaier commented Jul 25, 2024

This is a continuation of the issue from #1273. In that issue the gitignore code was changed to stop searching when it found a .git directory. However sdist bundles do not include that directory. This causes hatch to continue searching through parent directories until it finds one.

This is causing issues in Buildroot as we download the sdist for python-jsonschema-specifications and build it. But that project lacks a .gitignore. We recently added our own .gitignore containing just * to a parent directory in buildroot/buildroot@a14c862. But this inadvertently broke that package so it ignores everything.

In #1273 @ofek suggested stopping the search if PKG-INFO is found, which should fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant