Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEP 600 #280

Closed
mattip opened this issue Mar 20, 2020 · 5 comments
Closed

Support PEP 600 #280

mattip opened this issue Mar 20, 2020 · 5 comments

Comments

@mattip
Copy link
Contributor

mattip commented Mar 20, 2020

I am interested in getting PEP 600 and general manylinux_X_Y support out, since it turns out manylinux2014 limits us to glibc2.17, and NumPy has found that many trigonometric functions are inaccurate in that glibc. Also, the aarch64 gcc compiler in manylinux2014 has a bug that was fixed upstream but it seems will take quite some time to percolate out into the image. xref numpy/numpy#15763, numpy/numpy#7518, pypa/manylinux#494.

I am not sure how to do this and still respect the Package Installers section of the PEP. Any thoughts, especially in light of PR gh-262?

@brettcannon
Copy link
Member

In general the changes are probably going to be:

  1. Create a generator that yields all glibc versions from the current version on down to 2.5 where manylinux1 started
  2. Have that generator also emit the old manylinux tags at the right place to match what PEP 600 says they are now aliases for
  3. Also respect the new _manylinux module semantics when generating tags
  4. Update the rest of the code to use the new function

@brainwane
Copy link

I think there needs to be a tracking issue for full rollout and I asked about that in Discourse just now.

@mattip
Copy link
Contributor Author

mattip commented Apr 8, 2020

Does the tracking issue belong in pypa/manylinux ?

@mattip
Copy link
Contributor Author

mattip commented May 28, 2020

Closing, thanks

@mattip mattip closed this as completed May 28, 2020
@brainwane
Copy link

Thanks @mattip - pypa/manylinux#542 will be a good place for tracking this progress. And thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants