-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InvalidRequirement: name@ git+...@branch; (python_version=="...") and extra == "..." #432
Comments
Looks like the current parsing definition does not allow you to put parentheses around a marker expression without a boolean operator ( packaging/packaging/markers.py Lines 134 to 136 in 7350746
This is wrong because it is allowed by PEP 508:
where
So this is a bug in |
These aren't valid requirements. In #624, these error out appropriately as:
Again, with #624, Adding whitespace after the URL correctly parses this as:
|
So I think this is no longer relevant after the parser rewrite? |
It is -- #624 makes the additional changes needed to fix this issue. |
Hello. I found a requirement that packaging deems invalid but I am not sure why.
This is happening on 20.4, 20.9 and main branch @ 7350746.
I see what I believe is a proper requirement generated by https://github.com/sqlobject/sqlobject/blob/3.9.1/setup.py#L118-L121 as:
Parsed by
importlib.metadata.PathDistribution.requires
as:Failing with:
What's wrong with this requirement?
The text was updated successfully, but these errors were encountered: