-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PEP 621 project table parsing and validation module #647
Comments
I guess the first question is do we think this is a good fit for this project? For that I'm not sure as we have not really done front-end stuff before. We already have enough work just to keep up with the back-end-related, so I'm not sure if we want to take this extra work on if it isn't going to be used by e.g. pip (which I don't think pip does since it will read My next point is I don't think a custom |
To be clear, I still appreciate the work and I see value of this making it up to PyPI somehow, I just don't know if @pradyunsg and I think this project is the best fit. |
The point of this is for builders to use (flit, etc). This is what I'm using it for. |
I'm not sure if this is achieving quite the same purpose. |
Yeh can change names tuples for dataclasses, I'm not fussed either way |
It does basically use every aspect of this module, which is why I felt it was a good fit. But yeh up to you guys, I'll be using this code anyway 😄 |
Outside of the specifics of the implementation, I do think it's a good idea to have some sort of validation for the standards-backed |
FWIW, https://validate-pyproject.readthedocs.io/en/latest/index.html exists already. |
That's exactly what exception groups were designed for.
Sort of. I mean I think I'm +0 on the idea, but I personally don't have the capacity to do the review on the PR to get it merged (I'm already having to consider picking up Donald's draft PR for metadata to see it through). If I were to do this myself, I would write a module that did the following:
|
The recently adopted |
Because build-backends have a limitation in terms of dependencies and usually have to bundle them to prevent dependency cycles, I think it would be best if these things are concentrated in |
Would merging that into |
If there is no dependencies and the maintainers think that is a good idea, I think that would be fine. |
Sounds cool to me 😄 |
Great! cc @FFY00 @henryiii @frostming, which I think are the maintainers currently. What are your thoughts on that? |
Merging |
I don't think it's ready. There's still quite a bit of work to be done, like using the standard library |
Would a short term step of what @chrisjsewell originally proposed and doing something like
|
I think the main issue is with
It's also implemented on a custom class instead of using I think there are two options that would unblock this:
Especially if the later was chosen, I'd probably want a few cleanups that are easier with a completely new interface, like removing reliance on custom features of the EMailMessage-like class. |
As prototyped in #646, I believe this repo is a nice place to house a general parsing and validation function for the PEP 621
[project]
table in thepyproject.toml
.This returns a list of (build tool independent) validation errors and a
TypedDict
of theproject
data.The text was updated successfully, but these errors were encountered: