Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure under WASI due to assuming ctypes is always available #666

Closed
brettcannon opened this issue Jan 17, 2023 · 3 comments
Closed

Comments

@brettcannon
Copy link
Member

brettcannon commented Jan 17, 2023

________________ test_glibc_version_string_ctypes_raise_oserror ________________

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x21a84b0>

    def test_glibc_version_string_ctypes_raise_oserror(monkeypatch):
        def patched_cdll(name):
            raise OSError("Dynamic loading not supported")

>       monkeypatch.setattr(ctypes, "CDLL", patched_cdll)
E       AttributeError: None has no attribute 'CDLL'

tests/test_manylinux.py:146: AttributeError

def test_glibc_version_string_ctypes_raise_oserror(monkeypatch):
def patched_cdll(name):
raise OSError("Dynamic loading not supported")
monkeypatch.setattr(ctypes, "CDLL", patched_cdll)
assert _glibc_version_string_ctypes() is None

@brettcannon
Copy link
Member Author

Should just require an appropriate skipIf decorator.

@kevinchang96
Copy link
Contributor

Hi @brettcannon, I'd like to work on this issue. Can you please assign it to me?

@brettcannon
Copy link
Member Author

@kevinchang96 feel free to go ahead and submit a PR; I personally prefer not assigning issues to non-maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants