Fix prerelease detection for > and <
#794
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 13, 2024
|
Feedback would be appreciated. |
Is this for another PR? I don’t see the change here. |
It's in this PR, it's in the change to |
uranusjr
approved these changes
May 20, 2024
|
I tried to merge branch with 'main' to make sure this PR was still good, but forgot I don't have automatic CI rights, if someone could approve CI run I'd be appreciative. |
|
Anything blocking this? Do I need to do anything for a changelog entry here? |
pradyunsg
force-pushed
the
fix-prerelease-detection-for->-and-<
branch
from
d70d341
to
a0e7b90
Compare
brettcannon
requested changes
Aug 8, 2024
There was a problem hiding this comment.
#788 (comment) has some examples. We probably should have some tests for those.
notatallshaw
force-pushed
the
fix-prerelease-detection-for->-and-<
branch
from
0a4eec2
to
42c1f6d
Compare
Added specifier tests to match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #788
And adds an explicit test for
!=based on #776 (comment)