Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with removing preresolved dependency optimization #539

Closed
tetsuo-cpp opened this issue Mar 10, 2023 · 0 comments · Fixed by #540
Closed

Experiment with removing preresolved dependency optimization #539

tetsuo-cpp opened this issue Mar 10, 2023 · 0 comments · Fixed by #540
Assignees
Labels
enhancement New feature or request

Comments

@tetsuo-cpp
Copy link
Contributor

Currently we avoid invoking dependency resolution with hashed dependencies or when --no-deps are provided. This causes some inconsistency since pip is more accurate at finding dependencies than our hand-coded logic. Now that we've removed our own dependency resolution logic and are just shelling out to pip, we should experiment with removing this special case to see what the performance impact is like for large requirements files. If the slowdown is acceptable, we should consider removing the special case and repurposing the hashing logic and --no-deps flag to just pass this same flag down to the pip invocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant