From a09913673f267326c1471336c15f9c099a476969 Mon Sep 17 00:00:00 2001 From: Xavier Fernandez Date: Wed, 9 Jan 2019 22:59:59 +0100 Subject: [PATCH] Redact index password from logs Closes #6124 --- news/6124.bugfix | 1 + src/pip/_internal/cli/base_command.py | 9 +++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 news/6124.bugfix diff --git a/news/6124.bugfix b/news/6124.bugfix new file mode 100644 index 00000000000..94d1339e36a --- /dev/null +++ b/news/6124.bugfix @@ -0,0 +1 @@ +Redact the password from index urls in a debug message (using --no-index & --verbose options together) diff --git a/src/pip/_internal/cli/base_command.py b/src/pip/_internal/cli/base_command.py index 175dbadc14b..a8371aa8754 100644 --- a/src/pip/_internal/cli/base_command.py +++ b/src/pip/_internal/cli/base_command.py @@ -27,7 +27,9 @@ ) from pip._internal.req.req_file import parse_requirements from pip._internal.utils.logging import setup_logging -from pip._internal.utils.misc import get_prog, normalize_path +from pip._internal.utils.misc import ( + get_prog, normalize_path, redact_password_from_url, +) from pip._internal.utils.outdated import pip_version_check from pip._internal.utils.typing import MYPY_CHECK_RUNNING @@ -287,7 +289,10 @@ def _build_package_finder( """ index_urls = [options.index_url] + options.extra_index_urls if options.no_index: - logger.debug('Ignoring indexes: %s', ','.join(index_urls)) + logger.debug( + 'Ignoring indexes: %s', + ','.join(redact_password_from_url(url) for url in index_urls), + ) index_urls = [] return PackageFinder(