-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distutils config files deprecation too noisy, too early, wrong audience #10712
Comments
This comment has been minimized.
This comment has been minimized.
Here is another example of similar behaviour, with an extensive discussion #10556 and attempt to improve the message to be more factual and helpful : #10772 I think this should signal to PIP maintainers that maybe they should rethink the way they are communicating with their users. I believe that warnings should be:
In my opinion if warnings do not follow those principles (and this is just learning from developing Airflow and listening to thousands of users) the warnings will be simply treated as "noise" - wery similar to spam received. This makes them useless and rather tnan encourage them to a good behaviour, they make the users develop blind-spot and the users tend to ignore the warnings (even the important ones). I do not tell (and this is not my intention) to say "PIP is doing it wrong". Not at all. There are many cases where the warnings are good. But also I think PIP maintainers should be open to improve some of the warnings following those principles. I have a feeling that in many cases (certainly that was the case #10556) rational arguments loose a bit with some 'doctrinal' thinking and lack of being open and understanding that there are different kinds of users and use cases. Maybe that's deliberate and all PIP maintainers agree to that approach. Maybe that's just some people having extremely strong opinions and others not willing to get into opposing them. I have no idea, but the discussion there seems to ignore rational arguments. Kind request to PIP maintainers to consider that opinion and rethink the approach. |
@pradyunsg knowing that you work on improving the error output now, do you think this pip/src/pip/_internal/locations/__init__.py Line 378 in 052419f
deprecated() invocation and then, just print it out once, at the end of the process?
|
FWIW, I just installed 21.3 and then installed something fairly basic/essential and got >60 lines of this message. This is beyond useless to a user, and not even actionable for me while developing python programs. Minimizing the output would be nice, but it would appear on the surface that you're telling the wrong audience. No user controls how a package is built. Why not output these during the package build, not the package installation? |
I totally agree with @jorhett: the message is directed at the wrong audience, and unnecessarily repetitive/verbose in any case. |
I can't refrain from observing a pattern on pip, willing to teach others on how to do thins at all costs. Probably most people here are already aware of other similar tickets like the one about being used with root user or the outdated version check. At least the outdated check can be disabled but the others cannot. How about making a rule of not introducing any new messaging without ensuring that there is a way to silence it? I know that it was done in good faith, but way to hell is paved with good intentions.... |
No longer an issue since the warning has since done its job and retired. |
@uranusjr In PYthon 3.10? I still get it in the latest version of Python 3.9. |
From what I know 3.10 never has the issue. 3.9.11 and above (with pip 22.0 or later) should not contain the warning either. |
@uranusjr I'm using Python 3.9.12 and pip 22.0.4, and the warning message is still emitted. |
Description
When I install packages outside a virtualenv using Homebrew, I get multiple deprecation warnings per run; these warnings are not intended for me, seem unlikely to affect me for two years, and there is no way to silence them.
There is no rate-limit on this warning. There is no
pip --use-deprecated
option to quiet this warning.python3 -W ignore::DeprecationWarning -m pip
doesn't work (and arguably shouldn't);-W ignore::Warning
does work, but I assume there are other warnings I do want to see.Note that the simplest way of triggering this is just running
pip install
by itself:Expected behavior
I am a relatively sophisticated user. If my distro is doing something bad, maybe I want to hear about it. But I also want to hear about the timeframe it is likely to affect me. If we're talking about Python 3.12, I don't have to care for two years.
Many inexperienced users will become alarmed at these deprecation warnings, especially because they are printed so often.
My expectation is that this will be printed at most once per
pip
version upgrade:pip version
pip 21.3.1
Python version
Python 3.9.9 (Homebrew 3.3.6-72-g5096d6e; https://github.com/Homebrew/homebrew-core/blob/cb104b31ef5762265f3bf253493df23d1a533171/Formula/python%403.9.rb)
OS
macOS 11.6.1
How to Reproduce
python
python3 -m pip install
python3 -m pip install
python3 -m pip install
python3 -m pip install
Output
Code of Conduct
The text was updated successfully, but these errors were encountered: