fix: correct the way to decide if keyring is available #11774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Feb 3, 2023
src/pip/_internal/network/auth.py
Outdated
Comment on lines
361
to
364
| def _should_save_password_to_keyring(self) -> bool: | ||
| if get_keyring_provider() is None: | ||
| if isinstance(get_keyring_provider(), KeyRingNullProvider): | ||
| return False | ||
| return ask("Save credentials to keyring [y/N]: ", ["y", "n"]) == "y" |
There was a problem hiding this comment.
Maybe we should refactor this whole thing into the provider classes. Checking isinstance here feels like an anti-pattern.
There was a problem hiding this comment.
Updated, but may need to suggest a better name
uranusjr
approved these changes
Feb 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_keyring_provider()will never returnNone, correct it to use the right check. This also goes along with: