Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask a confirm message when upgrade or uninstall a package who depend by other packages. #4681

Closed
zaazbb opened this issue Aug 19, 2017 · 6 comments
Labels
auto-locked Outdated issues that have been locked by automation C: error messages Improving error messages state: needs discussion This needs some more discussion type: enhancement Improvements to functionality

Comments

@zaazbb
Copy link

zaazbb commented Aug 19, 2017

as the title say,
should Ask a confirm message when upgrade or uninstall a package who depend by other packages.

eg:
packageA needs packageB < 3.0, packageB current version is 1.0.
when upgrade packageB from 1.0 to 2.0, no need ask a confirm.
when upgrade packageB from 1.0 to 3.0, need ask a confirm, and show the dependence.
when uninstall packageB, need ask a confirm, and show the dependence.

@pradyunsg
Copy link
Member

Hi @zaazbb!

This is essentially #4245. I'm closing this as a duplicate of that. :)

@pradyunsg pradyunsg added the resolution: duplicate Duplicate of an existing issue/PR label Aug 19, 2017
@pradyunsg
Copy link
Member

Oh, sorry. I missed the upgrade part. :)

@pradyunsg pradyunsg reopened this Aug 20, 2017
@pradyunsg pradyunsg added type: enhancement Improvements to functionality state: needs discussion This needs some more discussion and removed resolution: duplicate Duplicate of an existing issue/PR labels Aug 20, 2017
@pradyunsg
Copy link
Member

This is really a workaround for #988, which would probably get resolved soon. :)

I'll keep this open for now until someone comes around to this and has time to think about what's been suggested.

@ghost
Copy link

ghost commented Aug 20, 2017

Right now pip-review, a project that I contribute to, calls pip install to upgrade all packages with no user interaction. Pip-review is needed because for various reasons (I perceived that such a feature would not be accepted without the dependency resolver), pip cannot automatically upgrade all packages. We have two options here:

  1. Don't ask for user input or implement an option to suppress all user input during installation
  2. Implement automatic upgrades of all packages

And now that I think about this some more, there are a lot of automated tools that depend on the no user input behavior of pip install. So this should not be implemented in any case without an option to suppress this (probably a -y).

@chrahunt
Copy link
Member

chrahunt commented Dec 8, 2019

This is a suggestion for a possible error flow for #988. Given that there are still a lot of unknowns related to the UX around conflicting dependencies, I think the best approach will be to handle this as a part of the overall changes that will be covered by #988 instead of as a separate issue. Whether to provide an escape hatch for conflicting dependencies, whether it should be interactive, and the need to have a non-interactive option for CI and scripted invocations of pip are all things that will be covered.

I will close this, but definitely keep on the lookout for user feedback requests as we move forward on that implementation!

@chrahunt chrahunt closed this as completed Dec 8, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jan 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
@brainwane brainwane added the C: error messages Improving error messages label Aug 5, 2020
@brainwane
Copy link
Contributor

@chrahunt thank you for your response! @nlhkabu I want to bring this to your attention -- is this something to reopen or to turn into a new issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: error messages Improving error messages state: needs discussion This needs some more discussion type: enhancement Improvements to functionality
Projects
None yet
Development

No branches or pull requests

4 participants