Make the upgrade-pip prompt look less like an error (to a new user)

[pradyunsg]

pip's current upgrade prompt can be confusing for new users where they confuse the upgrade advice as advice for fixing errors they're facing.

One of the solutions for this would be to make the upgrade prompt look different from the error output so that a new user does not confuse it with the same.

Context: pypa/packaging-problems#149

[tkzv]

The nagging prompt causes users to break the system. There should be an option to disable the prompt.

[pfmoore]

There is. There's a --disable-pip-version-check option for pip, and system redistributors can patch out or modify the prompt.

[ncoghlan]

Note that #5346 is a separate issue to silence this warning entirely when pip didn't get installed by pip. (see https://src.fedoraproject.org/rpms/python-pip/pull-request/5#request_diff for the downstream Fedora patch implementing that behaviour)

Upstream PR: https://github.com/pypa/pip/pull/5368/files

[pradyunsg]

The point of this issue here is not that pip's upgrade prompt can cause users to break their systems (that's a whole other deal). That's #5346 as @ncoghlan pointed out.

The point here is that for someone who's getting started, when they have an outdated pip and have an error in the installation, the upgrade instructions seem like the solution to the error in installation.

Either the message needs be clearer in that case or at least somehow show that it's not related to the error.

[ichard26]

This can probably be closed with the merge of #10959 which changed the prompt to be much less scary. Stealing the screenshot, here's what it looks like now: