Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A pip sdist command #6669

Closed
konstin opened this issue Jul 1, 2019 · 1 comment
Closed

A pip sdist command #6669

konstin opened this issue Jul 1, 2019 · 1 comment
Labels
auto-locked Outdated issues that have been locked by automation resolution: duplicate Duplicate of an existing issue/PR

Comments

@konstin
Copy link
Contributor

konstin commented Jul 1, 2019

What's the problem this feature will solve?
PEP 517 defines build_wheel and build_sdist to build a wheel and a source distribution respectively. build_wheel can be used through pip wheel, while build_sdist is not available through the cli, even though the frontend part is already implemented.

Describe the solution you'd like
A pip sdist command akin to pip wheel, which take the path to a local project path or a vcs project url and builds a source distribution.

This was originally proposed in #1323, which was closed with the comment that "[...] we're probably going to want a command like this when we get abstract build systems [...]".

My reason for resurrecting this is this issue comment. The idea is to verify that the source distribution is complete in a build backend independent fashion, i.e. run pip sdist . && pip install myproject-1.2.3.tar.gz in ci.

Alternative Solutions

The pip build command from #6041. If pip build deprecates pip wheel I'd be happy about that, otherwise I believe would still be a good idea to a pip sdist that is symmetric to pip wheel.

Additional context

Thread with some additional discussion: pypa/packaging-problems#219

@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Jul 1, 2019
@pradyunsg
Copy link
Member

pradyunsg commented Jul 2, 2019

There's an idea for a pip build command. See #6041. We will deprecate pip wheel if we go that route.

Closing as a duplicate since the build command would minimize the size of pip's CLI in terms of commands, and since I strongly prefer that anyway. :)

Thanks for filing this!

@chrahunt chrahunt added the resolution: duplicate Duplicate of an existing issue/PR label Jul 21, 2019
@triage-new-issues triage-new-issues bot removed the S: needs triage Issues/PRs that need to be triaged label Jul 21, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation resolution: duplicate Duplicate of an existing issue/PR
Projects
None yet
Development

No branches or pull requests

3 participants