Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn that direct URL will not be recorded when running setup.py install #9176

Open
llamafilm opened this issue Nov 30, 2020 · 7 comments
Open
Labels
project: setuptools Related to setuptools UX User experience related

Comments

@llamafilm
Copy link

Environment

  • pip version: 20.2.4
  • Python version: 3.7.9
  • OS: Windows 10
  • Running with Powershell in clean venv

Description
I forked a Github repo and made some minor changes. Then I installed from my own repo with pip, but pip freeze is not showing the full URL.

Expected behavior
It should show the full URL to the source repo, thanks to #7612. Some other repos are working correctly like this:

pip install git+https://github.com/pypa/packaging
...
pip freeze
GPUtil==1.4.0
packaging @ git+https://github.com/pypa/packaging@69855f324f58d7a421fc1791b7794dfa80cf519d
pyparsing==2.4.7

How to Reproduce

pip install git+https://github.com/llamafilm/gputil
Collecting git+https://github.com/llamafilm/gputil
  Cloning https://github.com/llamafilm/gputil to c:\users\elliott\appdata\local\temp\pip-req-build-gq70gug6
Using legacy 'setup.py install' for GPUtil, since package 'wheel' is not installed.
Installing collected packages: GPUtil
    Running setup.py install for GPUtil ... done
Successfully installed GPUtil-1.4.0

pip freeze
GPUtil==1.4.0
@uranusjr
Copy link
Member

Marking as duplicate to #8176.

@uranusjr uranusjr added the resolution: duplicate Duplicate of an existing issue/PR label Nov 30, 2020
@llamafilm
Copy link
Author

This is not the same as #8176. In this case pip list --format=freeze shows the same problem.

@uranusjr
Copy link
Member

Oh your issue has one more twist. setup.py install does not know how to record URLs. Can you try

  1. Uninstalling the package
  2. pip install wheel
  3. Install the package again

and check if freeze shows the URL?

@llamafilm
Copy link
Author

Aha! That does work.

@uranusjr
Copy link
Member

Maybe we can add a warning in this situation.

@uranusjr uranusjr reopened this Nov 30, 2020
@uranusjr uranusjr added project: setuptools Related to setuptools and removed resolution: duplicate Duplicate of an existing issue/PR labels Nov 30, 2020
@uranusjr uranusjr changed the title freeze does not include URL Warn that direct URL will not be recorded when running setup.py install Nov 30, 2020
@uranusjr uranusjr added the UX User experience related label Nov 30, 2020
@uranusjr
Copy link
Member

Tangentally related: setup.py install will be deprecated at some point (#8560).

@Mr-Pepe
Copy link
Contributor

Mr-Pepe commented Sep 30, 2022

Quick update and summary:

The PR for this issue (#9208) has been closed after being stale for a year and this issue will be obsolete when setup.py install gets deprecated, which is scheduled for April 2023 according to #8559.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: setuptools Related to setuptools UX User experience related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants