Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to a placeholder if a distribution's location is None #11710

Merged
merged 6 commits into from
Jan 16, 2023

Conversation

daniil-konovalenko
Copy link
Contributor

@daniil-konovalenko daniil-konovalenko commented Jan 7, 2023

Resolves #11704

I would love to hear some thoughts on the message wording. I feel it's not very friendly right now because it doesn't specify how pip found the package. Should we log the finder class that found the package, maybe? Not sure if it's possible though without changing the importlib API.

@daniil-konovalenko daniil-konovalenko marked this pull request as ready for review January 7, 2023 20:49
@uranusjr
Copy link
Member

uranusjr commented Jan 9, 2023

If I remember correctly, this is shown to the user, so including the finder class doesn’t feel like a good idea. Where would you need that information?

@daniil-konovalenko
Copy link
Contributor Author

If I remember correctly, this is shown to the user, so including the finder class doesn’t feel like a good idea. Where would you need that information?

Right, it's not the best thing to show to the user. It's just from the user point of view the current message doesn't explain much.
I don't see a better way at the moment, so I guess we could just merge it and be done with it, and maybe return to it in the future if needed.

@uranusjr uranusjr merged commit f34d6ab into pypa:main Jan 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip fails to log an existing distribution if its location attribute is None
2 participants