Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated noqa comments #12289

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Remove outdated noqa comments #12289

merged 1 commit into from
Oct 1, 2023

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Sep 22, 2023

This removes unnecessary noqa which are intended to hide linter errors and adds a ruff rule to prevent unnecessary noqa comments in the future.

@sbidoul sbidoul merged commit ff05e42 into pypa:main Oct 1, 2023
27 checks passed
@sbidoul
Copy link
Member

sbidoul commented Oct 1, 2023

Thank you @lgeiger !

@lgeiger lgeiger deleted the noqa branch October 1, 2023 23:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbidoul sbidoul sbidoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgeiger @sbidoul