Remove --sequential #5348
Merged
Remove --sequential #5348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now meaningless since we use pip batch install.
We now use the batch install method from pip directly, so it's meaningless.
Since we removed sequential options ...
|
I think we may need to deprecate the flag before we remove it in case people use it in their CI. |
|
I believe that people who use the flag in CI won't notice the difference, since it's a warning... A one off breakage is a risk we can take. If someone relied on the functionality, it's already gone. ... |
matteius
approved these changes
Sep 11, 2022
|
Hey, just a heads up that this does break CI. If you're using the |
tconkling
added a commit
to streamlit/streamlit
that referenced
this pull request
Sep 20, 2022
Remove obsolete (and now broken!) --sequential flag from `pipenv install` (Pipenv now incorrectly parses this flag as a package name, and throws an error when it can't install it.) pypa/pipenv#5348 We originally added the flag because Pipenv stated it "increased determinism" (and we were having issues with dependencies being resolved non-deterministically).
kmcgrady
pushed a commit
to streamlit/streamlit
that referenced
this pull request
Sep 21, 2022
Remove obsolete (and now broken!) --sequential flag from `pipenv install` (Pipenv now incorrectly parses this flag as a package name, and throws an error when it can't install it.) pypa/pipenv#5348 We originally added the flag because Pipenv stated it "increased determinism" (and we were having issues with dependencies being resolved non-deterministically).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.