Pipfile.lock() is not idempotent

[GPHemsley]

pipfile/pipfile/api.py

Lines 128 to 133 in 7d7c312

	def lock(self):
	"""Returns a JSON representation of the Pipfile."""
	data = self.data
	data['_meta']['hash'] = {"sha256": self.hash}
	data['_meta']['pipfile-spec'] = 6
	return json.dumps(data, indent=4, separators=(',', ': '))

Because line 130 is not using copy to copy self.data, the subsequent lines are mutating self.data, which is adding self.hash to the value self.data.

This causes every subsequent call to Pipfile.lock() to hash the hash, which means the hash changes every time.

import pipfile

p = pipfile.load("Pipfile")

hash_before = p.hash
print(hash_before)

p.lock()

hash_after = p.hash
print(hash_after)

print(hash_before == hash_after)