-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include_package_data=False reads MANIFEST.in in sdist command #110
Comments
@ostcar Isn't |
It was a long time ago, that I opened that ticket. I can not remember what that situation was. For all I care the ticket can be closed. |
Does this ticket still make sense? According to the latest interaction in #2835, setuptools will always "act like" building a sdist and then it will create a wheel based on that. Since (I also consider that |
I have no idea. It was a very long time that I opened this issue. It's ok for if you close it. |
Originally reported by: ostcar (Bitbucket: ostcar, GitHub: ostcar)
Your documentation defines, that the MANIFEST.in is only parsed, if include_package_data is set to True. So I suppose it is not read if include_package_data is set to False. That works fine for the 'build' or 'bdist' command. But the sdist commands includes parses the MANIFEST.in even if include_package_data is set to False.
This could probably be fixed in the method
commands.egg_info.manifest_maker.run
by changing the line
if os.path.exists(self.template)
toif os.path.exists(self.template) and self.distribution.include_package_data:
The text was updated successfully, but these errors were encountered: