Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_package_data=False reads MANIFEST.in in sdist command #110

Closed
ghost opened this issue Nov 18, 2013 · 4 comments
Closed

include_package_data=False reads MANIFEST.in in sdist command #110

ghost opened this issue Nov 18, 2013 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 18, 2013

Originally reported by: ostcar (Bitbucket: ostcar, GitHub: ostcar)


Your documentation defines, that the MANIFEST.in is only parsed, if include_package_data is set to True. So I suppose it is not read if include_package_data is set to False. That works fine for the 'build' or 'bdist' command. But the sdist commands includes parses the MANIFEST.in even if include_package_data is set to False.

This could probably be fixed in the method commands.egg_info.manifest_maker.run
by changing the line if os.path.exists(self.template) to if os.path.exists(self.template) and self.distribution.include_package_data:


@ghost ghost added major bug labels Mar 29, 2016
@tuukkamustonen
Copy link

@ostcar Isn't MANIFEST.in supposed to be always read when building sdist (but not when building wheel or egg). So this should be just about clarifying the documentation (that MANIFEST.in is read only when include_package_data is enabled or source distribution is being built)?

@ostcar
Copy link

ostcar commented Oct 23, 2017

It was a long time ago, that I opened that ticket. I can not remember what that situation was.

For all I care the ticket can be closed.

@abravalheri
Copy link
Contributor

abravalheri commented Nov 3, 2021

Does this ticket still make sense?

According to the latest interaction in #2835, setuptools will always "act like" building a sdist and then it will create a wheel based on that.

Since MANIFEST.in is always supposed to be read when building sdist, (as put by @tuukkamustonen), it will should also be read when creating a wheel.

(I also consider that bdist and eggs are deprecated)

@ostcar
Copy link

ostcar commented Nov 3, 2021

I have no idea. It was a very long time that I opened this issue. It's ok for if you close it.

@jaraco jaraco closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants