Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Improve coverage config #3050

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[CI] Improve coverage config #3050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ea7307
Cleanup coverage output
abravalheri Jan 8, 2022
08d4c3a
Produce both coverage reports (XML and term) on CI
abravalheri Jan 25, 2022
f3b1fc7
Coverage skip files completely covered in CI
abravalheri Feb 8, 2022
89d696d
Attempt to simplify configuration for coveragepy
abravalheri Feb 8, 2022
4952a1a
Add skip_covered since it is more appropriate for large code bases
abravalheri Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
[run]
source =
setuptools
pkg_resources
omit =
# leading `*/` for pytest-dev/pytest-cov#456
*/.tox/*
*/_vendor/*
*/_distutils/tests/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setuptools/_distutils/tests are not being run in the setuptools CI. So I think it make sense to omit them.


[report]
show_missing = True
skip_covered = True
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration is more appropriate for large projects such as setuptools, as indicated in #3050 (comment)

2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
- name: Run tests
shell: C:\cygwin\bin\env.exe CYGWIN_NOWINPATH=1 CHERE_INVOKING=1 C:\cygwin\bin\bash.exe -leo pipefail -o igncr {0}
run: |
tox -- --cov-report xml
tox -- --cov-report xml --cov-report term

integration-test:
needs: test
Expand Down