Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade GHA workflow to use v2 of the official actions #432

Closed
webknjaz opened this issue May 16, 2020 · 1 comment
Closed

Upgrade GHA workflow to use v2 of the official actions #432

webknjaz opened this issue May 16, 2020 · 1 comment
Labels
enhancement help wanted

Comments

@webknjaz
Copy link
Member

(https://twitter.com/webKnjaZ/status/1261678107439792129 follow-up)

So from what I saw, current workflows use actions/setup-python and actions/checkout that are v1 but both have v2 available.

It should be a low hanging fruit for somebody who wants to send an easy beginner-level PR.
@henryiii
Copy link
Contributor

v2 of setup python should be trivial (it basically just allows you to pin to any Python version), but v2 of checkout is probably a bit of a challenge to do nicely - it does not include the information needed for setuptools_scm, even with depth=0, so you have to unshallow, which is (IMO) uglier than using "v1" for now. Here's the issue: actions/checkout#249 .

JenSte added a commit to JenSte/aiotus that referenced this issue Aug 9, 2020
@JenSte
Downgrade version of checkout action
3e4e8a0 
Apparently v2 of the action does not maintain enough information for
setuptools-scm to work properly:
pypa/setuptools-scm#432
JenSte added a commit to JenSte/aiotus that referenced this issue Aug 9, 2020
@JenSte
Downgrade version of checkout action
3491a9f 
Apparently v2 of the action does not maintain enough information for
setuptools-scm to work properly:
pypa/setuptools-scm#432
RonnyPfannschmidt added a commit that referenced this issue Nov 28, 2020
@RonnyPfannschmidt
Merge pull request #494 from RonnyPfannschmidt/workflow-python-v2
fb84044 
fix #432 - update python workflows to v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RonnyPfannschmidt @webknjaz @henryiii