Fixes #418 Support keyring.get_credential #419
Conversation
|
The docs failure is not my fault (perhaps I should write some docs...?) - it's in the contributors guide. |
zooba
changed the title
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 78.29% 78.29% +<.01%
==========================================
Files 14 14
Lines 737 751 +14
Branches 106 108 +2
==========================================
+ Hits 577 588 +11
- Misses 127 130 +3
Partials 33 33
Continue to review full report at Codecov.
|
tests/test_utils.py
Outdated
| @pytest.fixture | ||
| def keyring_missing_get_credentials(monkeypatch): | ||
| """ | ||
| Simulate that 'import keyring' raises an ImportError |
There was a problem hiding this comment.
This docstring needs to be updated.
There was a problem hiding this comment.
So does the name that gets deleted immediately below... guess that's why the coverage didn't hit 100%?
|
@jaraco why are you merging changes for this project? I don't believe you were ever explicitly made a maintainer or asked to help |
Fixes #418 Support keyring.get_credential
This requires keyring 15.2 or later.