fish prompt: preserve pipestatus #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming release fish 3.1.0 provides a variable $pipestatus, that exposes the exit code of each process in a pipeline. This $pipestatus is also used by the new default prompt. Presently, $status is restored but not $pipestatus, so a prompt displaying the pipestatus is wrong: expected: (env) $ false | true | false (env) [1|0|1] $ actual: (env) $ false | true | false (env) [0|1] $ The wrong $pipestatus is because `echo 'exit 1' | source` is used to restore the $status. This commit solves this problem more elegantly by running the user's prompt immediately, and printing it later. Uses the fish builtin "string" command which exists since fish 2.3b1 (released April 19, 2016) so that's unlikely to cause problems.
4 tasks
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming release fish 3.1.0 provides a variable $pipestatus, that
exposes the exit code of each process in a pipeline. This $pipestatus
is also used by the new default prompt.
Presently, $status is restored but not $pipestatus, so a prompt displaying
the pipestatus is wrong:
expected:
actual:
The wrong $pipestatus is because
echo 'exit 1' | sourceis usedto restore the $status.
This commit solves this problem more elegantly by running the user's
prompt immediately, and printing it later.
Uses the fish builtin "string" command which exists since fish 2.3b1
(released April 19, 2016) so that's unlikely to cause problems.
Thanks for contributing a pull request, see checklist all is good!
docs/changelogfolder