Lower min version of six to 1.9 #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
master
branch
2 times, most recently
from
94fdcab
to
ac1730e
Compare
ssbarnea
changed the title
gaborbernat
requested changes
Feb 13, 2020
|
Let's keep all import from six other than the two ensure Which can be from virtualenv.util 🤷♂️ |
Done another round, metaclass was not really needed, lets check again after it reports green. |
This change should allow installation of virtualenv on systems with older six where their LTS support may prevent them from upgrading it.
|
AFAIK, i am done, now waiting for @gaborbernat to look again at this boring change. |
gaborbernat
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should allow installation of virtualenv on systems with older six where their LTS support may prevent them from upgrading it.
Fixes: #1605