-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --readonly-app-data option #2009
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2009 +/- ##
==========================================
+ Coverage 94.32% 94.36% +0.04%
==========================================
Files 86 87 +1
Lines 4280 4316 +36
==========================================
+ Hits 4037 4073 +36
Misses 243 243
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I believe this is ready for review now 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test suite on Windows 2.7 seems to be failing. The delta coverage is 90%
, can you please bring it up to 100%
? Otherwise conceptually the PR looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #2000
Thanks for contributing, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix_lint
)docs/changelog
folder