Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unfunctioing pydoc to fail #2049

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Allow unfunctioing pydoc to fail #2049

merged 2 commits into from
Jan 12, 2021

Conversation

d125q
Copy link
Contributor

@d125q d125q commented Jan 12, 2021

Otherwise, one cannot activate a virtualenv under Zsh with set -e.

As an example,

$ zsh -c 'set -ex; source /path/to/virtualenv/bin/activate; echo activated'
+zsh:1> source /path/to/virtualenvbin/activate
+/path/to/virtualenvbin/activate:5> [ '' '=' /path/to/virtualenvbin/activate ']'
+/path/to/virtualenvbin/activate:47> deactivate nondestructive
+deactivate:1> unset -f pydoc

fails with exit code 1 because there is nothing to unset. (The relevant version are: zsh 5.8.0.2-dev (x86_64-pc-linux-gnu), Python 3.9.1, and virtualenv 20.3.0.)

Otherwise, one cannot activate a virtualenv under Zsh with set -e.
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #2049 (1e1b76d) into main (a4025d6) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2049      +/-   ##
==========================================
- Coverage   94.04%   94.01%   -0.03%     
==========================================
  Files          87       87              
  Lines        4331     4331              
==========================================
- Hits         4073     4072       -1     
- Misses        258      259       +1     
Flag Coverage Δ
tests 94.01% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/seed/embed/base_embed.py 96.22% <0.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4025d6...1e1b76d. Read the comment docs.

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry, thanks!

@d125q
Copy link
Contributor Author

d125q commented Jan 12, 2021

Please add a changelog entry, thanks!

Added; thanks likewise!

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 26943f6 into pypa:main Jan 12, 2021
@gaborbernat
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants