Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub trusted publishers: support tag patterns #13911

Open
woodruffw opened this issue Jun 11, 2023 · 0 comments
Open

GitHub trusted publishers: support tag patterns #13911

woodruffw opened this issue Jun 11, 2023 · 0 comments

Comments

@woodruffw
Copy link
Member

Breakout from #12465, which is closed now that the MVP is done.

The current trusted publisher implementation for GitHub supports an optional environment name which, if supplied, can be used to additional constrain the corresponding GitHub Actions workflow to only run after explicit approval (among other possible restrictions).

Some users have indicated a desire for a similar option tag pattern, which would then allow them to use tag protection rules. These would be similar in security model to the existing environment name support, but would make trusted publishers applicable to a larger number of CI-based publishing workflows without requiring them to loosen their protection rules.

Some design constraints:

  • We should make sure the role/value of tag patterns and/or environment names is communicated clearly, both on the publisher management pages and in the PyPI docs;
  • We should make it hard for users to shoot themselves in the foot with tag patterns, e.g. we should almost certainly reject patterns like * as effectively useless.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants