Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust imports to updates in libpysal #272

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Adjust imports to updates in libpysal #272

merged 5 commits into from
Oct 24, 2023

Conversation

jGaboardi
Copy link
Member

dependabot bot and others added 4 commits September 14, 2023 22:46
@dependabot
Bump codecov/codecov-action from 3 to 4
8b7e19e 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3...v4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@jGaboardi
Merge pull request #22 from jGaboardi/dependabot/github_actions/codec…
b29eb58 
…ov/codecov-action-4

Bump codecov/codecov-action from 3 to 4
@jGaboardi
fix broken imports
1c941f6
@jGaboardi
codecov GHA v3
247a1b9
@jGaboardi jGaboardi mentioned this pull request Oct 24, 2023
Merged
@jGaboardi jGaboardi self-assigned this Oct 24, 2023
@jGaboardi jGaboardi added the bug label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #272 (2aba5ae) into main (3f5ce84) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #272   +/-   ##
=====================================
  Coverage   73.4%   73.4%           
=====================================
  Files         24      24           
  Lines       3284    3285    +1     
  Branches     518     518           
=====================================
+ Hits        2410    2411    +1     
  Misses       708     708           
  Partials     166     166
Files Coverage Δ
esda/getisord.py 67.1% <100.0%> (+0.1%) ⬆️
esda/smoothing.py 58.3% <100.0%> (ø)

martinfleis
martinfleis reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting pattern...

esda/getisord.py Outdated Show resolved Hide resolved
@jGaboardi @martinfleis
Update esda/getisord.py
2aba5ae 
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
@jGaboardi jGaboardi merged commit f6a8732 into pysal:main Oct 24, 2023
18 checks passed
@jGaboardi jGaboardi deleted the proper_imports branch October 24, 2023 13:58
@martinfleis
Copy link
Member

We will need to release this before the next lib will come. Just a note.

@jGaboardi
Copy link
Member Author

Any blockers at the moment? No time like the present.

@jGaboardi jGaboardi mentioned this pull request Oct 24, 2023
Closed
@martinfleis
Copy link
Member

We could easily do a patch just with this but also can wait. I don't assume lib will have a next release before end of the year.

@jGaboardi
Copy link
Member Author

So would it hurt to have an esda=2.5.1 release? I can trigger that if so. But also, would it hurt to have a libpysal=4.8.1?

@martinfleis
Copy link
Member

So would it hurt to have an esda=2.5.1 release?

no, better be ready.

But also, would it hurt to have a libpysal=4.8.1?

no need for that, we're not fixing anything a user would care about

@jGaboardi
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

@ljwolf ljwolf Awaiting requested review from ljwolf

@knaaptime knaaptime Awaiting requested review from knaaptime

Assignees

@jGaboardi jGaboardi

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access packages directly, not through libpysal.common
2 participants
@jGaboardi @martinfleis