Generalize also for haversine distance #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d metrics This address pysal#96 ps.: it also makes a small tweak on formating of spatial proximity profile
|
this looks good. though i'm still not sure why euclidian distance is failing in the first place... (i.e. the index in #96 shouldn't be zero) |
So, I rerun using the internal original function and got these results: #96 (comment) |
…o be handle (just like the first example of pysal#96 (comment))
|
Ok, the last two commits comprise what we recently discussed. The only thing that it is missing is the set of clever checking of the input .crs to guess if the user input is projected or not. I'll work on that, but any help on that will be really valuable! |
knaaptime
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address the issue raised in #96.