default to binary assignment for clients #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gegen07
approved these changes
Jun 13, 2023
|
@ljwolf Let me know what you think about this solution when you have a moment. |
|
Yes! Looks fine! I don't know if it will solve the problem generally, as I'm away from my windows laptop for a while that reproduced the problem. |
OK, shall we hold off merging until we can verify? |
|
CI failures are not related to this PR – see #386 |
|
@ljwolf I think there is no harm in merging this, even if we can't verify it fixes your specific use case. Thoughts? |
|
Indeed! Fine to merge this! |
This was referenced Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (hopefully) provides a solution to #364. Simply swapping out
pulp.LpIntegerforpulp.LpBinaryas the default inadd_client_assign_variableseems to do the trick and tests pass locally. @ljwolf Can you try this out on your data to see if it resolves the issue?