Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mentioning wheel in pypi install docs #1086

Closed
aiqc opened this issue Mar 9, 2022 · 3 comments
Closed

mentioning wheel in pypi install docs #1086

aiqc opened this issue Mar 9, 2022 · 3 comments

Comments

@aiqc
Copy link

aiqc commented Mar 9, 2022

It would be helpful to mention that wheel is required for the non-legacy install w pypi:
https://pysam.readthedocs.io/en/latest/installation.html#pypi-installation


Here is an install attempt on a fresh venv with/ without wheel:

image

^ let it run for ~3min then killed it


Recreated venv, installed wheel, and retried:

image

@FionaMoon
Copy link

Hi,
I also met this problem when I try to install pysam.
When I try to install pysam directly by pip install pysam:

error: legacy-install-failure

× Encountered error while trying to install package.
╰─> pysam

note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.

I'll try to install wheel as you say to see whether this problem can be solved.
Thank you!

@pettyalex
Copy link

One way to fix this would be to move to pyproject.toml, which allows projects to specify that they need wheel at install time: https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/

@jmarshall
Copy link
Member

I think typically wheel will already be installed, and in any case the O.P.'s Installation would likely have eventually succeeded in building from source if he had let it continue. Anyway, I've added a note about wheels vs sdists.

We do now use a pyproject.toml file, but I expect once pip has downloaded the sdist to see it, it will be committed to building from the sdist and will not go back to try a wheel instead. So updating the documentation now that wheels are commonplace suffices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants