Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exiting after failing commands is pretty unacceptable #965

Closed
gregmcinnes opened this issue Nov 3, 2020 · 2 comments
Closed

Exiting after failing commands is pretty unacceptable #965

gregmcinnes opened this issue Nov 3, 2020 · 2 comments

Comments

@gregmcinnes
Copy link

gregmcinnes commented Nov 3, 2020

I was excited to find this library but I don't think I can use it and feel confident running it at any sort of scale. It really needs to throw an error and report the error message if the underlying command fails. Otherwise it's difficult to trust anything that's run with this library.

I was contemplating creating a "success" file after the bcftools and running a separate script that checks for the success file, but that should not be necessary.

@leeleavitt
Copy link

It can be painful to debug, but please be more empathetic when you write these issues down.

@jmarshall
Copy link
Member

Duplicate of #506

@jmarshall jmarshall marked this as a duplicate of #506 Aug 23, 2021
@pysam-developers pysam-developers locked as resolved and limited conversation to collaborators Aug 23, 2021
@pysam-developers pysam-developers unlocked this conversation Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants