Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing latest tag and release #1275

Closed
Technetium1 opened this issue Feb 7, 2024 · 3 comments
Closed

Missing latest tag and release #1275

Technetium1 opened this issue Feb 7, 2024 · 3 comments
Labels
category: url url changes or extraction problems priority 1: high For issues that affect a ton of users type: bug something isn't working

Comments

@Technetium1
Copy link

Make sure you are on the latest version by running ani-cli -U

Metadata (please complete the following information)

Describe the bug

  • 129244a was pushed to master branch Dec 13, but a release was not created since then.

Steps To Reproduce

  • N/A

Expected behavior

  • 4.7.1 Should have been tagged and released already as the version was bumped in the commit; however, at this point I believe 4.7.2 is due as well.

Additional context

@Technetium1 Technetium1 added priority 2: medium Default for bugs type: bug something isn't working labels Feb 7, 2024
@port19x
Copy link
Collaborator

port19x commented Feb 7, 2024

Hi @Technetium1, the problem is in how we do versioning at ani-cli.
Every commit with changes to the ani-cli script that gets merged to master comes with a bump in the patch version.
This is even ensured by ci.
The minor version gets a bump in one of three scenarios:

  • A major outage happens, breaking the script for all users
  • A major feature gets added
  • Many small commits have accumulated since the last minor bump

Especially that last one is solely in my discretion

For completeness you may wonder when we bump the major version, this only happens after rewrites or source changes.

Now to your concrete problem.
I do agree that patching between releases is unreasonable.
An ani-cli-git package exists for the "bleeding edge" version that is v4.7.6 as of right now.
A new point release is planned after #1274, as there was a fix for windows users a couple PRs prior that we only now know to affect most of them.

I have chimed in at your chaotic aur request, thank you for helpin with it's inclusion there

@port19x port19x added priority 1: high For issues that affect a ton of users type: bug something isn't working category: url url changes or extraction problems and removed type: bug something isn't working priority 2: medium Default for bugs labels Feb 7, 2024
@port19x
Copy link
Collaborator

port19x commented Feb 7, 2024

Can confirm v4.7 broken on arch linux.
Will draft a release shortly, prior to #1274

@port19x
Copy link
Collaborator

port19x commented Feb 7, 2024

v4.8 out now, thank you for raising this issue

@port19x port19x closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: url url changes or extraction problems priority 1: high For issues that affect a ton of users type: bug something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants