-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0.0.dev3 Bolt.spec(config={}) is not passed to storm_conf when using sparse run
#263
Comments
Hmm... weird. I swear we do this in production at Parse.ly, but maybe we're only reading config options passed via the |
I've made additional change into FluxStormBolt/Spout so that there is a function, that appends configuration to storm config. But so far it accepts only strings or list of string. It has trouble with dictionaries, since Flux can't convert yaml dict to Java whatever automatically. The custom java classes, can be also included in project and set in project.clj, which mean I was able to "override" Flux default bolt with my behaviour. Which could be handy, even for Streamparse. Consider having custom Wrapper Bolt/Spout, so you can actually depend on Flux only on converting YAML to topology, and not on having proper "ShellBolt". |
Is there any progress on this issue? Are there alternative ways to instantiate Spouts/Bolts within a Topology definition with custom (non-global) parameters? @Darkless012 is this change published somewhere? |
I've made issue at Apache Storm https://issues.apache.org/jira/browse/STORM-1870 I've also made pullrequest #266 whenever the flux will be ready. However if you really need this, I was able to include custom java classes inside streamparse project, with this functionality. If you want to know more, please write me and email and we can discuss it further, but it includes custom version of streamparse code + java libraries inside project, which is a lot of fuss for "standard" user. However it is doable, since we need it in production. |
@Darkless012, this issue only affects |
sparse run
Well it affects also |
Any updates on this? |
Well, still waiting for upstream/Flux changes in Apache Storm. |
Could this also be related to setting the parallelism? If I try setting it to 4, it still stays set at 1. |
Do you mean parallelism of bolts and spouts? It is set in topologies/<name_of_topology>.py file, like here: http://streamparse.readthedocs.io/en/master/topologies.html#simple-python-example And it should work. |
One thing I should note is that you can now specify a |
https://issues.apache.org/jira/browse/STORM-1870 - Patch is ready for reviewing. |
Sorry to be late. STORM-1870 is merged and will be released to 1.1.0. |
hi I have the config passing issue, to get the fix do I need to update Storm or stremparse or both? I have storm 1.0.2 and sparse 3.1.1. thanks |
Once storm 1.1.0 is out, you'll just need to upgrade to that. Streamparse should not need to be upgraded. |
Will be fixed in 3.5.0 release coming out later today. |
foo_var is None.
How did you pass config to storm in your previous code (2.x.x) ShellBolt?
The text was updated successfully, but these errors were encountered: