Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for python 3.10: DeprecationWarning: isSet() is deprecated, use is_set() instead #132

Closed
CaselIT opened this issue May 26, 2021 · 4 comments · Fixed by #133
Closed

Comments

@CaselIT
Copy link

CaselIT commented May 26, 2021

Hi,

In SQLAlchemy we are trying to add support for python 3.10, (since we are starting to get issue about it, like sqlalchemy/sqlalchemy#6540)

We use xdist and currently we need to setup warn filters for some deprecation warning coming from this project. Like

INTERNALERROR>   File "/home/runner/work/sqlalchemy/sqlalchemy/.tox/github-cext/lib/python3.10/site-packages/xdist/workermanage.py", line 269, in setup
INTERNALERROR>     self.channel.setcallback(self.process_from_remote, endmarker=self.ENDMARK)
INTERNALERROR>   File "/home/runner/work/sqlalchemy/sqlalchemy/.tox/github-cext/lib/python3.10/site-packages/execnet/gateway_base.py", line 594, in setcallback
INTERNALERROR>     if not (self._closed or self._receiveclosed.isSet()):
INTERNALERROR>   File "/opt/hostedtoolcache/Python/3.10.0-beta.1/x64/lib/python3.10/threading.py", line 557, in isSet
INTERNALERROR>     warnings.warn('isSet() is deprecated, use is_set() instead',
INTERNALERROR> DeprecationWarning: isSet() is deprecated, use is_set() instead

It would be great it this package could be updated to support python 3.10 without having to setup warn filters

@nicoddemus
Copy link
Member

nicoddemus commented May 26, 2021

Hi @CaselIT,

Thanks for the report!

A PR removing those warnings would be great if you have the time to spare.

As it stands we are short on people maintaining execnet, so any help is welcome!

@CaselIT
Copy link
Author

CaselIT commented May 26, 2021

I'll try to look into it. Hopefully that's the only warning

@RonnyPfannschmidt
Copy link
Member

#127 needs to be released

@CaselIT
Copy link
Author

CaselIT commented May 27, 2021

I searched only among the issues and missed that PR. Then this can be closed once a new release is published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants