-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test process hanging forever #43
Comments
Original comment by @mgoral Hello, exactly same issue here, but with pytest 2.9.0, xdist 1.14 and execnet 1.4.1. In my situation child process was previously killed/died because of something, which execnet additionally reported by printing to stderr: Adding any timeout to workerpool.waitall(), be it the one passed into safe_terminate or any hardcoded value seems to fix the problem. |
Not sure if we could be hitting this issue as well (opensistemas-hub/osbrain#182). |
this was fixed in aca6845 |
@RonnyPfannschmidt I'm still experiencing an issue where my code appears to get stuck in the Would it be possible to just pass through the same timeout there, as well? |
I believe so, but someone has to implement it |
When you say that, do you just mean that someone has to create a PR with that change I suggested ( If you think there's nothing else to be done over and above that, I can create a tiny PR with that change |
I hadn't have a chance to investigate, but it should be a step in the right direction |
Ok, great, I created that as a PR just to move discussion over to there in case there is anything else to say about this |
We have a test job that uses pytest, xdist, execnet and it has been hanging forever on a regular basis.
Attaching in gdb it looks like it is waiting for a child but there is no child process. The relevant gdb python snippet:
In safe_terminate:
If the timeout value that is passed into safe_terminate is passed into waitall then it will timeout and exit the pytest test run.
This is working for us.
pytest 2.6.4, xdist 1.11, execnet 1.2.0
We haven't used execnet 1.3.0 yet, but that version hasn't modified the above code.
The text was updated successfully, but these errors were encountered: