Add .plugin member to PluginValidationError to access failing plugin #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
Jan 31, 2018
pluggy/manager.py
Outdated
| @@ -6,6 +6,10 @@ | |||
| class PluginValidationError(Exception): | |||
| """ plugin failed validation. """ | |||
There was a problem hiding this comment.
Please add this to the docs:
""" plugin failed validation.
:param object plugin: the plugin which failed validation, may be a module or an arbitrary object.
"""
nicoddemus
approved these changes
Jan 31, 2018
|
Thanks! |
|
Thanks @ids1024 can you please write a test for this which demonstrates and validates the feature. |
RonnyPfannschmidt
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this is to be able to call
.check_pending()catching the exception, then unregister the plugin and print a message, allowing the program to continue without that plugin. If there is already a way to do this, I haven't found it.