Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for user specified key/values in marks? #152

Closed
goodboy opened this issue May 22, 2018 · 3 comments
Closed

Allow for user specified key/values in marks? #152

goodboy opened this issue May 22, 2018 · 3 comments

Comments

@goodboy
Copy link
Contributor

goodboy commented May 22, 2018

Pertaining to the original request in #133 does it make sense to allow users to pass in custom key/val pairs to marks (via **kwargs or some other API) such that user defined collection and/or hook calling behaviour can be controlled/modified by the user based on their own inputs (maybe it's more relatable in the context of #151).

It would potentially look something like:

from pluggy import HookspecMarker

hookspec = HookspecMarker('blah')

@hookspec(historic=True, a_special_hook=True)
def my_special_hook(arg):
    """This hook is only collected in special cases."""
    pass
@RonnyPfannschmidt
Copy link
Member

lets wait for a real problem that needs this

i'd like to adopt a c4.2-ish approach where we only fix things that has a direct real world impact - abstract feature requests rarely yield a usable api in th first iteration

@goodboy
Copy link
Contributor Author

goodboy commented May 23, 2018

@RonnyPfannschmidt agreed just thought I'd log it for future reference/discussion.

@RonnyPfannschmidt
Copy link
Member

i think we can close this one

@RonnyPfannschmidt RonnyPfannschmidt closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants